Windows packaging: assert every linked OCCT toolkit has a DLL to ship

mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-09-25 01:40:57 +00:00

The previous guard only caught an empty glob. That is the wrong invariant.
The glob ships whatever the deps prefix holds, which is not the same as what
libslic3r links.

This fork sets BUILD_MODULE_ModelingAlgorithms=ON; upstream OrcaSlicer sets it
OFF. Upstream's DataExchange module pulls in most ModelingAlgorithms toolkits
transitively, but not TKFillet and TKOffset -- those two exist only because we
turned the module on. So a source build against a deps tree carried over from
upstream has 40 of the 42 OCCT DLLs. The glob copies all 40, the build
succeeds, and the slicer dies at launch with "error 126 (dependency not
found)". Reported by SoftFever, who named exactly those two DLLs.

CI is unaffected: the deps cache key is hashFiles('deps/**'), so flipping the
OCCT flag invalidated it and every shipped artifact has all 42.

Publish OCCT_LIBS from libslic3r as the single source of truth and check each
toolkit has a DLL, so the list can never drift from what we link. Verified
against a simulated stale prefix: the configure fails naming exactly
TKFillet.dll;TKOffset.dll, and passes when both are present.

Windows-only: every call site of the copy function is inside if (WIN32).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVzKmX6Y1aEteit1HTXG4Q

This commit is contained in:

Tommaso Bianchi

2026-07-10 08:48:11 +02:00

co-authored by

Claude Opus 4.8

parent d568e89c34

commit 546cef5f42

2 changed files with 23 additions and 7 deletions

									
										src/libslic3r/CMakeLists.txt
									
		+3
		
												View File
												
				@@ -595,6 +595,9 @@ set(OCCT_LIBS

				    TKMath

				    TKernel

				)

				# Publish the link list so the Windows packaging step can assert it ships a DLL for

				# every toolkit we link, instead of shipping whatever the deps prefix happens to hold.

				set(OCCT_LIBS "${OCCT_LIBS}" CACHE INTERNAL "OCCT toolkits linked by libslic3r")

				target_link_libraries(libslic3r

				    PUBLIC