juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-17 10:32:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests (#10906)

Browse Source 
* Get libslic3r tests closer to passing

I can't get geometry tests to do anything useful. I've added extra
output, but it hasn't helped me figure out why they don't work
yet. That's also probably the last broken 3mf test doesn't work.

The config tests were mostly broken because of config name changes.

The placeholder_parser tests have some things that may-or-may-not
still apply to Orca.

* Vendor a 3.x version of Catch2

Everything is surely broken at this point.

* Allow building tests separately from Orca with build_linux.sh

* Remove unnecessary log message screwing up ctest

Same solution as Prusaslicer

* Make 2 TriangleMesh methods const

Since they can be.

* Move method comment to the header where it belongsc

* Add indirectly-included header directly

Transform3d IIRC

* libslic3r tests converted to Catch2 v3

Still has 3 failing tests, but builds and runs.

* Disable 2D convex hull test and comment what I've learned

Not sure the best way to solve this yet.

* Add diff compare method for DynamicConfig

Help the unit test report errors better.

* Perl no longer used, remove comment line

* Clang-format Config.?pp

So difficult to work with ATM

* Remove cpp17 unit tests

Who gives a shit

* Don't need explicit "example" test

We have lots of tests to serve as examples.

* Leave breadcrumb to enable sla_print tests

* Fix serialization of DynamicConfig

Add comments to test, because these code paths might not be even used
anymore.

* Update run_unit_tests to run all the tests

By the time I'm done with the PR all tests will either excluded by
default or passing, so just do all.

* Update how-to-test now that build_linux.sh builds tests separately

* Update cmake regenerate instructions

Read this online; hopefully works.

* Enable slic3rutils test with Catch2 v3

* Port libnest2d and fff_print to Catch2 v3

They build. Many failing.

* Add slightly more info to Objects not fit on bed exception

* Disable failing fff_print tests from running

They're mostly failing for "objects don't fit on bed" for an
infinite-sized bed. Given infinite bed is probably only used in tests,
it probably was incidentally broken long ago.

* Must checkout tests directory in GH Actions

So we get the test data

* Missed a failing fff_print test

* Disable (most/all) broken libnest2d tests

Trying all, not checking yet though

* Fix Polygon convex/concave detection tests

Document the implementation too. Reorganize the tests to be cleaner.

* Update the test script to run tests in parallel

* Get sla_print tests to build

Probably not passing

* Don't cause full project rebuild when updating test CMakeLists.txts

* Revert "Clang-format Config.?pp"

This reverts commit 771e4c0ad2.

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
This commit is contained in:
coryrc
2025-12-08 06:42:11 -08:00
committed by GitHub
parent 02c8bba8b4
commit 52c2a85d28
388 changed files with 59565 additions and 19524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

134
tests/libslic3r/test_geometry.cpp
View File

@@ -1,4 +1,4 @@
#include <catch2/catch.hpp>
#include <catch2/catch_all.hpp>
#include "libslic3r/Point.hpp"
#include "libslic3r/BoundingBox.hpp"
@@ -33,7 +33,7 @@ TEST_CASE("Line::parallel_to", "[Geometry]"){
Line l4(l2);
l4.rotate(1.1 * EPSILON, { 0, 0 });
REQUIRE(! l.parallel_to(l4));
REQUIRE_FALSE(l.parallel_to(l4));
// The angle epsilon is so low that vectors shorter than 100um rotated by epsilon radians are not rotated at all.
Line l5{ { 20000, 0 }, { 0, 0 } };
@@ -48,13 +48,13 @@ TEST_CASE("Line::parallel_to", "[Geometry]"){
l4.rotate(1., { 0, 0 });
l4.translate(offset);
REQUIRE(l.parallel_to(l3));
REQUIRE(!l.parallel_to(l4));
REQUIRE_FALSE(l.parallel_to(l4));
}
TEST_CASE("Line::perpendicular_to", "[Geometry]") {
Line l{ { 100000, 0 }, { 0, 0 } };
Line l2{ { 0, 200000 }, { 0, 0 } };
REQUIRE(! l.perpendicular_to(l));
REQUIRE_FALSE(l.perpendicular_to(l));
REQUIRE(l.perpendicular_to(l2));
Line l3(l2);
@@ -63,7 +63,7 @@ TEST_CASE("Line::perpendicular_to", "[Geometry]") {
Line l4(l2);
l4.rotate(1.1 * EPSILON, { 0, 0 });
REQUIRE(! l.perpendicular_to(l4));
REQUIRE_FALSE(l.perpendicular_to(l4));
// The angle epsilon is so low that vectors shorter than 100um rotated by epsilon radians are not rotated at all.
Line l5{ { 0, 20000 }, { 0, 0 } };
@@ -78,7 +78,7 @@ TEST_CASE("Line::perpendicular_to", "[Geometry]") {
l4.rotate(1., { 0, 0 });
l4.translate(offset);
REQUIRE(l.perpendicular_to(l3));
REQUIRE(! l.perpendicular_to(l4));
REQUIRE_FALSE(l.perpendicular_to(l4));
}
TEST_CASE("Polygon::contains works properly", "[Geometry]"){
@@ -125,7 +125,7 @@ SCENARIO("polygon_is_convex works") {
WHEN("Polygon is convex clockwise") {
Polygon cw_square { { {0, 0}, {0,10}, {10,10}, {10,0} } };
THEN("it is not convex") {
REQUIRE(! polygon_is_convex(cw_square));
REQUIRE_FALSE(polygon_is_convex(cw_square));
}
}
WHEN("Polygon is convex counter-clockwise") {
@@ -138,7 +138,7 @@ SCENARIO("polygon_is_convex works") {
GIVEN("A concave polygon") {
Polygon concave = { {0,0}, {10,0}, {10,10}, {0,10}, {0,6}, {4,6}, {4,4}, {0,4} };
THEN("It is not convex") {
REQUIRE(! polygon_is_convex(concave));
REQUIRE_FALSE(polygon_is_convex(concave));
}
}
}
@@ -380,15 +380,77 @@ SCENARIO("Polygon convex/concave detection", "[Geometry]"){
Point(200,100),
Point(200,200),
Point(100,200)}));
THEN("It has 4 convex points counterclockwise"){
REQUIRE(square.concave_points(PI*4/3).size() == 0);
REQUIRE(square.convex_points(PI*2/3).size() == 4);
}
THEN("It has 4 concave points clockwise"){
square.make_clockwise();
REQUIRE(square.concave_points(PI*4/3).size() == 4);
REQUIRE(square.convex_points(PI*2/3).size() == 0);
}
WHEN("Angle threshold is not set") {
THEN("It has 4 convex points counterclockwise"){
auto cave_pts = square.concave_points();
auto vex_pts = square.convex_points();
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 0);
REQUIRE(vex_pts.size() == 4);
}
THEN("It has 4 concave points clockwise"){
square.make_clockwise();
auto cave_pts = square.concave_points();
auto vex_pts = square.convex_points();
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 4);
REQUIRE(vex_pts.size() == 0);
}
}
WHEN("Angle threshold is greater than right angle") {
double angle_threshold = M_PI*4/3;
THEN("It has no convex points counterclockwise"){
auto cave_pts = square.concave_points(angle_threshold);
auto vex_pts = square.convex_points(angle_threshold);
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 0);
REQUIRE(vex_pts.size() == 0);
}
THEN("It has no concave points clockwise"){
square.make_clockwise();
auto cave_pts = square.concave_points(angle_threshold);
auto vex_pts = square.convex_points(angle_threshold);
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 0);
REQUIRE(vex_pts.size() == 0);
}
}
WHEN("Angle threshold is less than right angle") {
double angle_threshold = M_PI/3;
THEN("It has 4 convex points counterclockwise"){
auto cave_pts = square.concave_points(angle_threshold);
auto vex_pts = square.convex_points(angle_threshold);
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 0);
REQUIRE(vex_pts.size() == 4);
}
THEN("It has 4 concave points clockwise"){
square.make_clockwise();
auto cave_pts = square.concave_points(angle_threshold);
auto vex_pts = square.convex_points(angle_threshold);
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 4);
REQUIRE(vex_pts.size() == 0);
}
}
WHEN("Angle threshold is equal to right angle") {
double angle_threshold = M_PI/2;
THEN("It has no convex points counterclockwise"){
auto cave_pts = square.concave_points(angle_threshold);
auto vex_pts = square.convex_points(angle_threshold);
CAPTURE(cave_pts);
CAPTURE(vex_pts);
REQUIRE(cave_pts.size() == 0);
REQUIRE(vex_pts.size() == 0);
}
}
}
GIVEN("A Square with an extra colinearvertex"){
auto square = Slic3r::Polygon /*new_scale*/(Points({
@@ -398,8 +460,8 @@ SCENARIO("Polygon convex/concave detection", "[Geometry]"){
Point(100,200),
Point(100,100)}));
THEN("It has 4 convex points counterclockwise"){
REQUIRE(square.concave_points(PI*4/3).size() == 0);
REQUIRE(square.convex_points(PI*2/3).size() == 4);
REQUIRE(square.concave_points().size() == 0);
REQUIRE(square.convex_points().size() == 4);
}
}
GIVEN("A Square with an extra collinear vertex in different order"){
@@ -410,8 +472,8 @@ SCENARIO("Polygon convex/concave detection", "[Geometry]"){
Point(150,100),
Point(200,100)}));
THEN("It has 4 convex points counterclockwise"){
REQUIRE(square.concave_points(PI*4/3).size() == 0);
REQUIRE(square.convex_points(PI*2/3).size() == 4);
REQUIRE(square.concave_points().size() == 0);
REQUIRE(square.convex_points().size() == 4);
}
}
@@ -422,8 +484,8 @@ SCENARIO("Polygon convex/concave detection", "[Geometry]"){
Point(31286371,461008)
}));
THEN("it has three convex vertices"){
REQUIRE(triangle.concave_points(PI*4/3).size() == 0);
REQUIRE(triangle.convex_points(PI*2/3).size() == 3);
REQUIRE(triangle.concave_points().size() == 0);
REQUIRE(triangle.convex_points().size() == 3);
}
}
@@ -435,26 +497,8 @@ SCENARIO("Polygon convex/concave detection", "[Geometry]"){
Point(31286371,461012)
}));
THEN("it has three convex vertices"){
REQUIRE(triangle.concave_points(PI*4/3).size() == 0);
REQUIRE(triangle.convex_points(PI*2/3).size() == 3);
}
}
GIVEN("A polygon with concave vertices with angles of specifically 4/3pi"){
// Two concave vertices of this polygon have angle = PI*4/3, so this test fails
// if epsilon is not used.
auto polygon = Slic3r::Polygon(Points({
Point(60246458,14802768),Point(64477191,12360001),
Point(63727343,11060995),Point(64086449,10853608),
Point(66393722,14850069),Point(66034704,15057334),
Point(65284646,13758387),Point(61053864,16200839),
Point(69200258,30310849),Point(62172547,42483120),
Point(61137680,41850279),Point(67799985,30310848),
Point(51399866,1905506),Point(38092663,1905506),
Point(38092663,692699),Point(52100125,692699)
}));
THEN("the correct number of points are detected"){
REQUIRE(polygon.concave_points(PI*4/3).size() == 6);
REQUIRE(polygon.convex_points(PI*2/3).size() == 10);
REQUIRE(triangle.concave_points().size() == 0);
REQUIRE(triangle.convex_points().size() == 3);
}
}
}
@@ -482,8 +526,8 @@ SCENARIO("Ported from xs/t/14_geometry.t", "[Geometry]"){
REQUIRE(Slic3r::Geometry::directions_parallel(0, M_PI, 0));
REQUIRE(Slic3r::Geometry::directions_parallel(0, 0, M_PI / 180));
REQUIRE(Slic3r::Geometry::directions_parallel(0, M_PI, M_PI / 180));
REQUIRE(! Slic3r::Geometry::directions_parallel(M_PI /2, M_PI, 0));
REQUIRE(! Slic3r::Geometry::directions_parallel(M_PI /2, PI, M_PI /180));
REQUIRE_FALSE(Slic3r::Geometry::directions_parallel(M_PI /2, M_PI, 0));
REQUIRE_FALSE(Slic3r::Geometry::directions_parallel(M_PI /2, PI, M_PI /180));
}
}