juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-10-04 14:20:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check the Project Refresh Test's Result Directly

Browse Source 
Shellcheck SC2181: test the checker's exit status in the if instead of
reading $? afterwards.
This commit is contained in:
Hanif Koh
2026-10-01 16:38:03 +08:00
parent cb422fc500
commit 4b56c2a514
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/cli/test_cli_project_missing_keys.sh
+5 -2
View File
@@ -87,7 +87,7 @@ with open(dst + ".expected.json", "w") as f:
EOF EOF
check() { check() {
"$PY" - "$WORK/$1/out.3mf" "$WORK/old.3mf.expected.json" "$1" <<'EOF' if ! "$PY" - "$WORK/$1/out.3mf" "$WORK/old.3mf.expected.json" "$1" <<'EOF'
import json, sys, zipfile import json, sys, zipfile
with zipfile.ZipFile(sys.argv[1]) as z: with zipfile.ZipFile(sys.argv[1]) as z:
@@ -99,7 +99,10 @@ for e in errors:
print("FAIL: " + e) print("FAIL: " + e)
sys.exit(1 if errors else 0) sys.exit(1 if errors else 0)
EOF EOF
[ $? -eq 0 ] || { tail -n 40 "$WORK/$1/log"; exit 1; } then
tail -n 40 "$WORK/$1/log"
exit 1
fi
} }
slice project "$WORK/old.3mf" slice project "$WORK/old.3mf"