juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-07-21 09:52:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent script execution during shutdown

Browse Source 
Skip script action calls when the application
is closing to avoid post-teardown issues.
This commit is contained in:
Andrew
2026-07-13 19:20:23 +08:00
parent c3ebf38a07
commit 476fa73e43
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/slic3r/GUI/SpeedDialDialog.cpp
View File

@@ -270,10 +270,14 @@ private:
} }
// why: value-capture only. Script execution may outlive this popup if the app is closing. // why: value-capture only. Script execution may outlive this popup if the app is closing.
wxGetApp().CallAfter([id] { wxGetApp().CallAfter([id] {
// why: the queue may drain during shutdown, after MainFrame/Plater teardown;
// skip like the ScriptActionSource callbacks do instead of running into it.
if (wxGetApp().is_closing())
return;
AppActionRunResult o = wxGetApp().action_registry().run(id); AppActionRunResult o = wxGetApp().action_registry().run(id);
if (o.level == AppActionRunResult::Level::Busy) if (o.level == AppActionRunResult::Level::Busy)
return; return;
if (!o.message.IsEmpty()) if (!o.message.IsEmpty() && wxGetApp().plater())
wxGetApp().plater()->get_notification_manager()->push_notification( wxGetApp().plater()->get_notification_manager()->push_notification(
NotificationType::CustomNotification, NotificationType::CustomNotification,
o.level == AppActionRunResult::Level::Error ? NotificationManager::NotificationLevel::ErrorNotificationLevel : o.level == AppActionRunResult::Level::Error ? NotificationManager::NotificationLevel::ErrorNotificationLevel :