From 3cf0f4dba5f092d2ddb2dacc86acbac76d04d4a3 Mon Sep 17 00:00:00 2001 From: raistlin7447 Date: Mon, 29 Jun 2026 19:03:44 -0600 Subject: [PATCH] test(fff_print): re-enable tests disabled by the m_origin clipper throw (#14482) PR #13712 fixed the uninitialized Print::m_origin (commit 99dea01cc3, "Fix coord out-of-range exception caused by m_origin memory not initialized to 0") that made headless slice() intermittently throw ClipperLib's "Coordinate outside allowed range". With that root cause fixed, the three tests disabled for it pass again, so drop their [NotWorking] tags. --- tests/fff_print/test_printgcode.cpp | 5 +---- tests/fff_print/test_skirt_brim.cpp | 8 ++------ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/tests/fff_print/test_printgcode.cpp b/tests/fff_print/test_printgcode.cpp index 4e09072fff..8a65679104 100644 --- a/tests/fff_print/test_printgcode.cpp +++ b/tests/fff_print/test_printgcode.cpp @@ -31,10 +31,7 @@ boost::regex perimeters_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; perimeter"); boost::regex infill_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; infill"); boost::regex skirt_regex("G1 X[-0-9.]* Y[-0-9.]* E[-0-9.]* ; skirt"); -// [NotWorking]: slice() intermittently throws clipper's "Coordinate outside allowed -// range" in CI (Linux) while passing locally. Disabled pending a root-cause fix in a -// follow-up PR. -SCENARIO( "PrintGCode basic functionality", "[PrintGCode][NotWorking]") { +SCENARIO( "PrintGCode basic functionality", "[PrintGCode]") { GIVEN("A default configuration and a print test object") { WHEN("the output is executed with no support material") { Slic3r::Print print; diff --git a/tests/fff_print/test_skirt_brim.cpp b/tests/fff_print/test_skirt_brim.cpp index 7bd3259925..5529abe615 100644 --- a/tests/fff_print/test_skirt_brim.cpp +++ b/tests/fff_print/test_skirt_brim.cpp @@ -32,10 +32,7 @@ using namespace Slic3r; return brim_tool; } -// [NotWorking]: slice() intermittently throws clipper's "Coordinate outside allowed -// range" in CI (Linux) while passing locally. Disabled pending a root-cause fix in a -// follow-up PR. -TEST_CASE("Skirt height is honored", "[SkirtBrim][NotWorking]") { +TEST_CASE("Skirt height is honored", "[SkirtBrim]") { DynamicPrintConfig config = Slic3r::DynamicPrintConfig::full_print_config(); config.set_deserialize_strict({ { "skirt_loops", 1 }, @@ -55,8 +52,7 @@ TEST_CASE("Skirt height is honored", "[SkirtBrim][NotWorking]") { REQUIRE(layers_with_role(gcode, "skirt").size() == (size_t)config.opt_int("skirt_height")); } -// [NotWorking]: see "Skirt height is honored" above; same CI-only clipper range throw. -SCENARIO("Skirt and brim generation", "[SkirtBrim][NotWorking]") { +SCENARIO("Skirt and brim generation", "[SkirtBrim]") { GIVEN("A default configuration") { DynamicPrintConfig config = Slic3r::DynamicPrintConfig::full_print_config(); config.set_num_extruders(4);