juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-20 11:53:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

PhysicalPrinterDialog: Fixed memory leak

Browse Source
This commit is contained in:
YuSanka
2020-09-08 16:11:01 +02:00
parent ce06fc6cb7
commit 3c14d883a1
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/slic3r/GUI/PhysicalPrinterDialog.cpp
View File

@@ -187,8 +187,7 @@ PhysicalPrinterDialog::PhysicalPrinterDialog(wxString printer_name) :
PhysicalPrinter* printer = printers.find_printer(into_u8(printer_name)); PhysicalPrinter* printer = printers.find_printer(into_u8(printer_name));
if (!printer) { if (!printer) {
const Preset& preset = wxGetApp().preset_bundle->printers.get_edited_preset(); const Preset& preset = wxGetApp().preset_bundle->printers.get_edited_preset();
//FIXME Vojtech: WTF??? Memory leak? m_printer = PhysicalPrinter(into_u8(printer_name), m_printer.config, preset);
printer = new PhysicalPrinter(into_u8(printer_name), m_printer.config, preset);
// if printer_name is empty it means that new printer is created, so enable all items in the preset list // if printer_name is empty it means that new printer is created, so enable all items in the preset list
m_presets.emplace_back(new PresetForPrinter(this, preset.name)); m_presets.emplace_back(new PresetForPrinter(this, preset.name));
} }
@@ -197,9 +196,8 @@ PhysicalPrinterDialog::PhysicalPrinterDialog(wxString printer_name) :
const std::set<std::string>& preset_names = printer->get_preset_names(); const std::set<std::string>& preset_names = printer->get_preset_names();
for (const std::string& preset_name : preset_names) for (const std::string& preset_name : preset_names)
m_presets.emplace_back(new PresetForPrinter(this, preset_name)); m_presets.emplace_back(new PresetForPrinter(this, preset_name));
m_printer = *printer;
} }
assert(printer);
m_printer = *printer;
if (m_presets.size() == 1) if (m_presets.size() == 1)
m_presets.front()->SuppressDelete(); m_presets.front()->SuppressDelete();