From 35999b7110187160fd4f10c41c65e6f9b1faefde Mon Sep 17 00:00:00 2001 From: "xin.zhang" Date: Thu, 4 Sep 2025 11:13:16 +0800 Subject: [PATCH] FIX: fail to connect default machine when start studio jira: [none] Change-Id: Iec546016ec2852899a64c927c57ef3e79d62f9a8 (cherry picked from commit aa5cf6e0636511352bfd6c4c4ffd23cea42a8a70) --- src/slic3r/GUI/GUI_App.cpp | 15 --------------- src/slic3r/GUI/GUI_App.hpp | 1 - src/slic3r/GUI/MainFrame.cpp | 1 - src/slic3r/GUI/MainFrame.hpp | 1 - 4 files changed, 18 deletions(-) diff --git a/src/slic3r/GUI/GUI_App.cpp b/src/slic3r/GUI/GUI_App.cpp index 972a7debce..f150858098 100644 --- a/src/slic3r/GUI/GUI_App.cpp +++ b/src/slic3r/GUI/GUI_App.cpp @@ -2663,7 +2663,6 @@ bool GUI_App::on_init_inner() preset_bundle->backup_user_folder(); - Bind(EVT_SET_SELECTED_MACHINE, &GUI_App::on_set_selected_machine, this); Bind(EVT_UPDATE_MACHINE_LIST, &GUI_App::on_update_machine_list, this); Bind(EVT_USER_LOGIN, &GUI_App::on_user_login, this); Bind(EVT_USER_LOGIN_HANDLE, &GUI_App::on_user_login_handle, this); @@ -4306,18 +4305,6 @@ void GUI_App::enable_user_preset_folder(bool enable) } } -void GUI_App::on_set_selected_machine(wxCommandEvent &evt) -{ - // Orca: do not connect to default device during app startup, because some of the lan machines might not online yet - // and user will be prompted by several "Connect XXX failed" error message. - return; - - DeviceManager* dev = Slic3r::GUI::wxGetApp().getDeviceManager(); - if (dev) { - dev->set_selected_machine(m_agent->get_user_selected_machine()); - } -} - void GUI_App::on_update_machine_list(wxCommandEvent &evt) { /* DeviceManager* dev = Slic3r::GUI::wxGetApp().getDeviceManager(); @@ -4338,8 +4325,6 @@ void GUI_App::on_user_login_handle(wxCommandEvent &evt) boost::thread update_thread = boost::thread([this, dev] { dev->update_user_machine_list_info(); - auto evt = new wxCommandEvent(EVT_SET_SELECTED_MACHINE); - wxQueueEvent(this, evt); }); if (online_login) { diff --git a/src/slic3r/GUI/GUI_App.hpp b/src/slic3r/GUI/GUI_App.hpp index c725a15921..74770788e5 100644 --- a/src/slic3r/GUI/GUI_App.hpp +++ b/src/slic3r/GUI/GUI_App.hpp @@ -468,7 +468,6 @@ public: void handle_http_error(unsigned int status, std::string body); void on_http_error(wxCommandEvent &evt); - void on_set_selected_machine(wxCommandEvent& evt); void on_update_machine_list(wxCommandEvent& evt); void on_user_login(wxCommandEvent &evt); void on_user_login_handle(wxCommandEvent& evt); diff --git a/src/slic3r/GUI/MainFrame.cpp b/src/slic3r/GUI/MainFrame.cpp index 635549d97f..e3de84dfcf 100644 --- a/src/slic3r/GUI/MainFrame.cpp +++ b/src/slic3r/GUI/MainFrame.cpp @@ -84,7 +84,6 @@ wxDEFINE_EVENT(EVT_USER_LOGIN_HANDLE, wxCommandEvent); wxDEFINE_EVENT(EVT_CHECK_PRIVACY_VER, wxCommandEvent); wxDEFINE_EVENT(EVT_CHECK_PRIVACY_SHOW, wxCommandEvent); wxDEFINE_EVENT(EVT_SHOW_IP_DIALOG, wxCommandEvent); -wxDEFINE_EVENT(EVT_SET_SELECTED_MACHINE, wxCommandEvent); wxDEFINE_EVENT(EVT_UPDATE_MACHINE_LIST, wxCommandEvent); wxDEFINE_EVENT(EVT_UPDATE_PRESET_CB, SimpleEvent); diff --git a/src/slic3r/GUI/MainFrame.hpp b/src/slic3r/GUI/MainFrame.hpp index e69a95da0c..faa6e10708 100644 --- a/src/slic3r/GUI/MainFrame.hpp +++ b/src/slic3r/GUI/MainFrame.hpp @@ -430,7 +430,6 @@ wxDECLARE_EVENT(EVT_USER_LOGIN_HANDLE, wxCommandEvent); wxDECLARE_EVENT(EVT_CHECK_PRIVACY_VER, wxCommandEvent); wxDECLARE_EVENT(EVT_CHECK_PRIVACY_SHOW, wxCommandEvent); wxDECLARE_EVENT(EVT_SHOW_IP_DIALOG, wxCommandEvent); -wxDECLARE_EVENT(EVT_SET_SELECTED_MACHINE, wxCommandEvent); wxDECLARE_EVENT(EVT_UPDATE_MACHINE_LIST, wxCommandEvent); wxDECLARE_EVENT(EVT_UPDATE_PRESET_CB, SimpleEvent);