Copilot review fixes & upstream code interaction fix (#34)

* first pass at review issue 8
* delete detritus
* fix build compile error due to upstream changes
This commit is contained in:
Joseph Robertson
2026-05-27 21:53:04 -05:00
committed by GitHub
parent 0f75d6bc4e
commit 2dc4900292
5 changed files with 29 additions and 17 deletions
+1 -4
View File
@@ -1117,10 +1117,7 @@ void GLVolumeCollection::render(GLVolumeCollection::ERenderType type,
shader->set_uniform("print_volume.type", -1);
}
bool enable_support;
int support_threshold_angle = get_selection_support_threshold_angle(enable_support);
float normal_z = -::cos(Geometry::deg2rad((float) support_threshold_angle));
const float normal_z = get_selection_support_normal_z();
// Compute up direction accounting for build plate tilt
Vec3f up_direction = Vec3f::UnitZ();