juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-08-05 17:17:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some errors uncovered via compiler warnings (#7954)

Browse Source 
* fix: tray_exist_bits != tray_exist_bits comparison

* fix: title == GetTitle() == title comparison

* fix: possibly dangling reference to a temporary
```
OrcaSlicer/src/libslic3r/calib.cpp:456:17: warning: possibly dangling reference to a temporary [-Wdangling-reference]
  456 |     const auto &w         = bed_ext.size().x();
OrcaSlicer/src/libslic3r/calib.cpp:456:45: note: the temporary was destroyed at the end of the full expression ‘((Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 2>, 1>*)(& Slic3r::BoundingBoxBase<PointClass>::size() const [with PointClass = Eigen::Matrix<double, 2, 1, 2>]()))->Eigen::DenseCoeffsBase<Eigen::Matrix<double, 2, 1, 2>, 1>::x()’
  456 |     const auto &w         = bed_ext.size().x();
```

* fix: mixup of | and ||
in this case I think it actually does not change the semantics it just means that both comparison have to be evaluated.

* fix: multi-character character constants need "

OrcaSlicer/src/slic3r/GUI/MediaPlayCtrl.cpp:392: warning: multi-character character constant [-Wmultichar]
  392 |     if (auto n = tunnel.find_first_of('/_'); n != std::string::npos)
OrcaSlicer/src/slic3r/GUI/MediaPlayCtrl.cpp: In member function ‘void Slic3r::GUI::MediaPlayCtrl::Stop(const wxString&)’:
OrcaSlicer/src/slic3r/GUI/MediaPlayCtrl.cpp:392: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘12127’ to ‘95’ [-Woverflow]

* fix: missing paranthesis - skips null check

* NFC: Remove this check it can never be false

* NFC: fix warning: statement has no effect
This commit is contained in:
Marius Wachtler
2025-01-08 12:06:39 +07:00
committed by GitHub
parent 7834f78c90
commit 2b95ef4e3b
12 changed files with 26 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/slic3r/Utils/UndoRedo.cpp
View File

@@ -1071,7 +1071,7 @@ bool StackImpl::has_redo_snapshot() const
// BBS: undo-redo until modify record
auto it = std::lower_bound(m_snapshots.begin(), m_snapshots.end(), Snapshot(m_active_snapshot_time));
for (it; it != m_snapshots.end(); ++it) {
for (; it != m_snapshots.end(); ++it) {
if (snapshot_modifies_project(*it))
return true;
}
@@ -1340,12 +1340,12 @@ bool StackImpl::has_real_change_from(size_t time) const
Snapshot(m_active_snapshot_time));
if (it_active == m_snapshots.end()) return true;
if (it_active > it_time) {
for (it_time; it_time < it_active; ++it_time) {
for (; it_time < it_active; ++it_time) {
if (snapshot_modifies_project(*it_time))
return true;
}
} else {
for (it_active; it_active < it_time; ++it_active) {
for (; it_active < it_time; ++it_active) {
if (snapshot_modifies_project(*it_active))
return true;
}