juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-05-19 19:33:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Optimize the convex hull calculation logic when checking for overlaps between the assembly and sensitive areas.

Browse Source 
Jira: STUDIO-13686

Change-Id: I7ec402e7da150fd6f22eac079c7e4809d42eabde
(cherry picked from commit 16bff83ca2a4269b7c792f3485a902b5d027433e)
This commit is contained in:
weizhen.xie
2025-07-30 16:21:39 +08:00
committed by Noisyfox
parent 0f6cc6da4a
commit 1d52ab4738
1 changed files with 22 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
src/libslic3r/Print.cpp
View File

@@ -929,52 +929,33 @@ static StringObjectException layered_print_cleareance_valid(const Print &print,
wrapping_poly.points.emplace_back(scale_(pt.x() + print_origin.x()), scale_(pt.y() + print_origin.y())); wrapping_poly.points.emplace_back(scale_(pt.x() + print_origin.x()), scale_(pt.y() + print_origin.y()));
} }
std::map<const PrintInstance*, Polygon> map_model_object_to_convex_hull; std::map<const ModelVolume*, Polygon> map_model_volume_to_convex_hull;
// sequential_print_horizontal_clearance_valid
Polygons convex_hulls_other; Polygons convex_hulls_other;
for (int k = 0; k < print_instances_ordered.size(); k++) for (auto& inst : print_instances_ordered) {
{ for (const ModelVolume *v : inst->print_object->model_object()->volumes) {
auto& inst = print_instances_ordered[k]; if (!v->is_model_part()) continue;
auto it_convex_hull = map_model_object_to_convex_hull.find(inst); auto it_convex_hull = map_model_volume_to_convex_hull.find(v);
// Get convex hull of all printable volumes assigned to this print object. if (it_convex_hull == map_model_volume_to_convex_hull.end()) {
const ModelInstance* model_instance0 = inst->model_instance; auto volume_hull = v->get_convex_hull_2d(Geometry::assemble_transform(Vec3d::Zero(), inst->model_instance->get_rotation(),
if (it_convex_hull == map_model_object_to_convex_hull.end()) { inst->model_instance->get_scaling_factor(), inst->model_instance->get_mirror()));
// Calculate the convex hull of a printable object. volume_hull.translate(inst->shift - inst->print_object->center_offset());
auto convex_hull0 = inst->print_object->model_object()->convex_hull_2d(
Geometry::assemble_transform(Vec3d::Zero(), model_instance0->get_rotation(), model_instance0->get_scaling_factor(), model_instance0->get_mirror()));
double z_diff = Geometry::rotation_diff_z(model_instance0->get_rotation(), inst->model_instance->get_rotation()); it_convex_hull = map_model_volume_to_convex_hull.emplace_hint(it_convex_hull, v, volume_hull);
if (std::abs(z_diff) > EPSILON) }
convex_hull0.rotate(z_diff); Polygon &convex_hull = it_convex_hull->second;
Polygons convex_hulls_temp;
// instance.shift is a position of a centered object, while model object may not be centered. convex_hulls_temp.push_back(convex_hull);
// Conver the shift from the PrintObject's coordinates into ModelObject's coordinates by removing the centering offset. if (!intersection(exclude_polys, convex_hull).empty()) {
convex_hull0.translate(inst->shift - inst->print_object->center_offset()); return {inst->model_instance->get_object()->name + L(" is too close to exclusion area, there may be collisions when printing.") + "\n",
inst->model_instance->get_object()};
it_convex_hull = map_model_object_to_convex_hull.emplace_hint(it_convex_hull, inst, convex_hull0);
}
Polygon& convex_hull = it_convex_hull->second;
Polygons convex_hulls_temp;
convex_hulls_temp.push_back(convex_hull);
if (!intersection(convex_hulls_other, convex_hulls_temp).empty()) {
if (warning) {
warning->string = inst->model_instance->get_object()->name + L(" is too close to others, there may be collisions when printing.") + "\n";
warning->object = inst->model_instance->get_object();
} }
}
if (!intersection(exclude_polys, convex_hull).empty()) {
return {inst->model_instance->get_object()->name + L(" is too close to exclusion area, there may be collisions when printing.") + "\n", inst->model_instance->get_object()};
/*if (warning) {
warning->string = inst->model_instance->get_object()->name + L(" is too close to exclusion area, there may be collisions when printing.") + "\n";
warning->object = inst->model_instance->get_object();
}*/
}
if (print_config.enable_wrapping_detection.value && !intersection(wrapping_poly, convex_hull).empty()) { if (print_config.enable_wrapping_detection.value && !intersection(wrapping_poly, convex_hull).empty()) {
return {inst->model_instance->get_object()->name + L(" is too close to clumping detection area, there may be collisions when printing.") + "\n", return {inst->model_instance->get_object()->name + L(" is too close to clumping detection area, there may be collisions when printing.") + "\n",
inst->model_instance->get_object()}; inst->model_instance->get_object()};
}
convex_hulls_other.emplace_back(convex_hull);
} }
convex_hulls_other.emplace_back(convex_hull);
} }
//BBS: add the wipe tower check logic //BBS: add the wipe tower check logic