Fix support preview artifacts (missing layers) (#13310)

Fix support preview artifacts caused by incorrect gap subdivision

Support generation could sometimes split a gap into too many steps,
even when it should fit exactly into a single layer.

This was most noticeable when max_suport_layer_height was equal to
the print layer height (e.g. 0.2 mm).

This resulted in incorrect support layering and visible artifacts
in preview.

The issue was caused by floating-point precision, where values that
should be equal to the configured limit were treated as slightly larger.

Fix by biasing the subdivision calculation with EPSILON so near-equal
values are not split into extra steps.

Applied consistently to:
- SupportMaterial (normal supports)
- TreeSupportCommon (tree stepping)
- TreeSupport (layer creation)
This commit is contained in:
Kiss Lorand
2026-04-23 16:20:06 +03:00
committed by GitHub
parent ff3ad5ed98
commit 0c7e16aa36
3 changed files with 20 additions and 11 deletions

View File

@@ -2882,8 +2882,9 @@ SupportGeneratorLayersPtr PrintObjectSupportMaterial::raft_and_intermediate_supp
intermediate_layers.push_back(&layer_new); intermediate_layers.push_back(&layer_new);
} }
} else { } else {
// Insert intermediate layers. // ORCA: Bias by EPSILON so a gap effectively equal to
size_t n_layers_extra = size_t(ceil(dist / m_slicing_params.max_suport_layer_height)); // max_suport_layer_height is not split by floating-point noise.
size_t n_layers_extra = size_t(ceil((dist - EPSILON) / m_slicing_params.max_suport_layer_height));
assert(n_layers_extra > 0); assert(n_layers_extra > 0);
coordf_t step = dist / coordf_t(n_layers_extra); coordf_t step = dist / coordf_t(n_layers_extra);
if (extr1 != nullptr && extr1->layer_type == SupporLayerType::TopContact && if (extr1 != nullptr && extr1->layer_type == SupporLayerType::TopContact &&
@@ -2898,7 +2899,9 @@ SupportGeneratorLayersPtr PrintObjectSupportMaterial::raft_and_intermediate_supp
layer_new.height = extr1->height; layer_new.height = extr1->height;
intermediate_layers.push_back(&layer_new); intermediate_layers.push_back(&layer_new);
dist = extr2z - extr1z; dist = extr2z - extr1z;
n_layers_extra = size_t(ceil(dist / m_slicing_params.max_suport_layer_height)); // ORCA: Recalculate with the same EPSILON bias after re-anchoring at the top
// contact layer so near-equal gaps do not gain an extra split here either.
n_layers_extra = size_t(ceil((dist - EPSILON) / m_slicing_params.max_suport_layer_height));
if (n_layers_extra == 0) if (n_layers_extra == 0)
continue; continue;
// Continue printing the other layers up to extr2z. // Continue printing the other layers up to extr2z.

View File

@@ -1157,12 +1157,17 @@ void TreeSupport::create_tree_support_layers()
// Layers between the raft contacts and bottom of the object. // Layers between the raft contacts and bottom of the object.
double dist_to_go = m_slicing_params.object_print_z_min - raft_print_z; double dist_to_go = m_slicing_params.object_print_z_min - raft_print_z;
auto nsteps = int(ceil(dist_to_go / m_slicing_params.max_suport_layer_height)); // ORCA: Guard tiny residual raft-to-object gaps so the EPSILON-biased ceil()
double height = dist_to_go / nsteps; // below cannot turn them into zero steps after floating-point accumulation.
for (int i = 0; i < nsteps; ++i) { if (dist_to_go > EPSILON) {
raft_print_z += height; // ORCA: Bias by EPSILON so near-equal gaps do not get an extra split from FP noise.
raft_slice_z = raft_print_z - height / 2; auto nsteps = int(ceil((dist_to_go - EPSILON) / m_slicing_params.max_suport_layer_height));
m_object->add_tree_support_layer(layer_id++, height, raft_print_z, raft_slice_z); double height = dist_to_go / nsteps;
for (int i = 0; i < nsteps; ++i) {
raft_print_z += height;
raft_slice_z = raft_print_z - height / 2;
m_object->add_tree_support_layer(layer_id++, height, raft_print_z, raft_slice_z);
}
} }
m_raft_layers = layer_id; m_raft_layers = layer_id;
} }

View File

@@ -343,7 +343,8 @@ public:
} }
if (double dist_to_go = slicing_params.object_print_z_min - z; dist_to_go > EPSILON) { if (double dist_to_go = slicing_params.object_print_z_min - z; dist_to_go > EPSILON) {
// Layers between the raft contacts and bottom of the object. // Layers between the raft contacts and bottom of the object.
auto nsteps = int(ceil(dist_to_go / slicing_params.max_suport_layer_height)); // ORCA: Bias by EPSILON so near-equal gaps do not get an extra split from FP noise.
auto nsteps = int(ceil((dist_to_go - EPSILON) / slicing_params.max_suport_layer_height));
double step = dist_to_go / nsteps; double step = dist_to_go / nsteps;
for (int i = 0; i < nsteps; ++ i) { for (int i = 0; i < nsteps; ++ i) {
z += step; z += step;