juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-08-10 19:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove porting jargon and provenance notes from comments

Browse Source
This commit is contained in:
SoftFever
2026-07-18 01:46:23 +08:00
parent 4683c17f6f
commit 0b4cb89f7c
19 changed files with 97 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/slic3r/Utils/BBLNetworkPlugin.cpp
View File

@@ -187,10 +187,9 @@ int BBLNetworkPlugin::initialize(bool using_backup, const std::string& version)
int BBLNetworkPlugin::unload()
{
// Orca: destroy the plugin agent while its creating DLL is still loaded, so the void* handle
// never dangles into freed memory. Skipping this makes a network-plugin hot reload (unload +
// reload) crash: the stale m_agent survives the unload, create_agent() then short-circuits on
// has_agent() and keeps the dangling old-DLL handle, and the next call into the freshly loaded
// DLL (e.g. install_device_cert from the device-refresh timer) dereferences it -> access violation.
// never dangles into freed memory. A stale m_agent surviving the unload makes create_agent()
// short-circuit on has_agent() after a hot reload, and the next call into the freshly loaded
// DLL dereferences the old-DLL handle -> access violation.
destroy_agent();
UnloadFTModule();