juli/OrcaSlicer
1
1
Fork 0
mirror of https://github.com/OrcaSlicer/OrcaSlicer.git synced 2026-09-27 02:41:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ladder rung 9: grade the engine against 50 real drawings, not against my taste

Browse Source 
Ported from snaporca 5b82c846f3.
This commit is contained in:
Tommaso Bianchi
2026-08-22 23:28:36 +02:00
parent 1274d97983
commit 05ce2607a8
4 changed files with 391 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/slic3r/GUI/CAD/DesignSketchTool.cpp
+11 -3
View File
@@ -2311,7 +2311,7 @@ bool DesignSketchTool::try_add_constraints(const std::vector<SketchEntityConstra
return false;
}
void DesignSketchTool::infer_auto_constraints(int base)
void DesignSketchTool::infer_auto_constraints(int base, double ang_tol_rad)
{
const int n = int(m_entities.size());
if (base < 0 || base >= n) return;
@@ -2357,7 +2357,7 @@ void DesignSketchTool::infer_auto_constraints(int base)
// so a single conflict never drops the others).
for (int i = base; i < n; ++i) {
if (m_entities[i].type != SketchEntity::Type::Line) continue;
auto ax = infer_axis_constraint(m_entities[i].p0, m_entities[i].p1);
auto ax = infer_axis_constraint(m_entities[i].p0, m_entities[i].p1, ang_tol_rad);
if (!ax) continue;
SketchEntityConstraintDef c;
c.type = *ax;
@@ -8896,7 +8896,15 @@ int DesignSketchTool::add_entities_scripted(const std::vector<SketchEntity>& ent
if (ents.empty()) return -1;
const int base = int(m_entities.size());
for (const SketchEntity& e : ents) m_entities.push_back(e);
infer_auto_constraints(base); // the same auto-coincidence/H/V pass a gesture runs
// Auto-constrain, but do NOT let the inference move what the caller specified. A gesture
// gets 3 degrees of slack because a hand cannot click an exact horizontal; a scripted add
// has already said exactly what it means, and snapping a segment 2 degrees off to exactly
// horizontal silently rewrites it. Measured on a real drawing: feeding the 64 flattened
// segments of one circle moved vertices by up to 0.058 mm and shrank the enclosed area by
// 0.067%, because several segments of the polygon fell inside that 3 degree window. Exact
// coincidence inference is unaffected — it already tests to 1e-6 — so chains still weld
// and genuinely axis-aligned scripted geometry still gets its Horizontal/Vertical.
infer_auto_constraints(base, 1e-4);
resolve_live();
return base;
}